Re: patch: psql variables tabcomplete

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch: psql variables tabcomplete
Date: 2010-10-10 22:47:01
Message-ID: 23469.1286750821@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> 2010/10/4 Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>:
>> We don't have commands for display a list of such variables and \echo is
>> not tab-completed even with the patch. "Only supported by \set" might be
>> a bit unbalanced.

> it's good idea. I looked on it - and it is job for other patch. Some
> test are in experimental patch. But this needs more work - output is
> little bit ugly - I thing so prefix and suffix should not be showed.

I went ahead and applied this (with some cleanup). I don't see a very
good reason why the prefix/suffix shouldn't be shown in the completion
data --- after all, that *is* what it's going to type for you. In any
case, preventing that would take some fundamental hacking of the
readline interface; which would be way more work than it's worth,
and probably not very portable across the different versions of
readline either. So I think we should just be happy with this
behavior.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jon Nelson 2010-10-10 22:50:22 Re: Slow count(*) again...
Previous Message David Newall 2010-10-10 22:42:30 rollback to savepoint leads to transaction already in progress