Re: Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() during startup.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() during startup.
Date: 2017-09-16 18:30:21
Message-ID: 23456.1505586621@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> Looking into it.

I wonder whether we shouldn't just revert this patch altogether.
Certainly, extra reads of pg_control are not a noticeable performance
problem. I'm now quite worried about whether we aren't introducing
hazards of using stale values from the file; if a system crash isn't
enough to get it to flush its cache, then what is?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2017-09-16 18:38:49 Re: Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() during startup.
Previous Message Andres Freund 2017-09-16 18:26:34 Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() during startup.

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-09-16 18:38:49 Re: Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() during startup.
Previous Message Andres Freund 2017-09-16 18:26:34 Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() during startup.