Re: pgsql: Allow compute_query_id to be set to 'auto' and make it default

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Allow compute_query_id to be set to 'auto' and make it default
Date: 2021-05-15 18:43:31
Message-ID: 2343035.1621104211@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Allow compute_query_id to be set to 'auto' and make it default

culicidae seems unhappy:

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=culicidae&dt=2021-05-15%2018%3A20%3A08

/mnt/resource/andres/bf/culicidae/HEAD/pgsql.build/../pgsql/src/backend/postmaster/postmaster.c: In function \342\200\230save_backend_variables\342\200\231:
/mnt/resource/andres/bf/culicidae/HEAD/pgsql.build/../pgsql/src/backend/postmaster/postmaster.c:6172:33: error: \342\200\230auto_query_id_enabled\342\200\231 undeclared (first use in this function)
6172 | param->auto_query_id_enabled = auto_query_id_enabled;
| ^~~~~~~~~~~~~~~~~~~~~
/mnt/resource/andres/bf/culicidae/HEAD/pgsql.build/../pgsql/src/backend/postmaster/postmaster.c:6172:33: note: each undeclared identifier is reported only once for each function it appears in
/mnt/resource/andres/bf/culicidae/HEAD/pgsql.build/../pgsql/src/backend/postmaster/postmaster.c: In function \342\200\230restore_backend_variables\342\200\231:
/mnt/resource/andres/bf/culicidae/HEAD/pgsql.build/../pgsql/src/backend/postmaster/postmaster.c:6406:2: error: \342\200\230auto_query_id_enabled\342\200\231 undeclared (first use in this function)
6406 | auto_query_id_enabled = param->auto_query_id_enabled;
| ^~~~~~~~~~~~~~~~~~~~~
make[3]: *** [../../../src/Makefile.global:920: postmaster.o] Error 1

Not sure why it's only that animal.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-05-15 19:16:39 Re: pgsql: Allow compute_query_id to be set to 'auto' and make it default
Previous Message Alvaro Herrera 2021-05-15 18:14:18 pgsql: Allow compute_query_id to be set to 'auto' and make it default