Re: BUG #18057: unaccent removes intentional spaces

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: martin(at)schlossarek(dot)me, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #18057: unaccent removes intentional spaces
Date: 2023-08-19 16:30:04
Message-ID: 2334732.1692462604@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> I was looking at the code, and my first impression was right. All
> leading and trailing whitespaces between the two characters listed in
> the rule file are discarded. The thing is that we clearly document
> the parsing rules for the sake of any custom files one can feed to the
> extension:
> https://www.postgresql.org/docs/devel/unaccent.html

> I am not sure what we can do here. Doing nothing is certainly an
> option, but I am wondering if we could put in place an extra rule
> where whitespaces can be part of the translated character if it uses
> double quotes, for example. Thoughts?

Yeah, we could extend the parsing rules that way. It would break
any rules files that currently use double quote as a plain character,
but it seems unlikely that there are any. In any case, as long as
this wasn't back-patched I think such a change would be acceptable.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2023-08-19 17:19:22 Re: BUG #18059: Unexpected error 25001 in stored procedure
Previous Message PG Bug reporting form 2023-08-18 14:28:36 BUG #18061: The psql -v variable option does not work for the -c command option