From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Mark Dilger <hornschnorter(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Hao Lee <mixtrue(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
Subject: | Re: Windows build broken starting at da9b580d89903fee871cf54845ffa2b26bda2e11 |
Date: | 2018-05-15 15:58:04 |
Message-ID: | 23275.1526399884@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Mark Dilger <hornschnorter(at)gmail(dot)com> writes:
> My best guess at the moment is:
> diff --git a/src/backend/utils/init/globals.c b/src/backend/utils/init/globals.c
> index c1f0441b08..0a3163398f 100644
> --- a/src/backend/utils/init/globals.c
> +++ b/src/backend/utils/init/globals.c
> @@ -16,8 +16,11 @@
> *
> *-------------------------------------------------------------------------
> */
> +#include <sys/stat.h>
> +
> #include "postgres.h"
> +#include "common/file_perm.h"
Yipes. Frost, you didn't really do that did you? That's a blatant
break of the "c.h must come first" rule. Whether or not it broke the
Windows build, there are other platforms it'll break.
> Indeed, the following change (shown here for illustrative purposes only; please
> don't commit it this way) fixes the problem, at least in my build environment:
That's pretty ugly, but what happens if you just move the <sys/stat.h>
inclusion to immediately after postgres.h, as is our normal custom?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-05-15 16:06:12 | Re: Allow COPY's 'text' format to output a header |
Previous Message | Isaac Morland | 2018-05-15 15:52:54 | Re: Allow COPY's 'text' format to output a header |