Re: BUG #17045: 14 Beta Tighten up allowed names for custom GUC parameters breaks PostgREST

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Sosinski <robert(dot)sosinski(at)reactive(dot)io>
Cc: pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #17045: 14 Beta Tighten up allowed names for custom GUC parameters breaks PostgREST
Date: 2021-06-02 22:58:17
Message-ID: 232375.1622674697@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Robert Sosinski <robert(dot)sosinski(at)reactive(dot)io> writes:
> I would revise my statement to say this change to PostgreSQL 14 would
> significantly break existing PostgREST applications, to the point that they
> would be unable to upgrade to 14.

Fair enough. I also dug around a bit and noted that the core grammar
explicitly allows SET/SHOW variable names to have any number of
components:

var_name: ColId { $$ = $1; }
| var_name '.' ColId
{ $$ = psprintf("%s.%s", $1, $3); }
;

That dates clear back to commit 3dc37cd8d of 2004-05-26. While it's
fair to wonder how intentional it was, given that the commit log
message only mentions "qualified name in the form <ID>.<ID>",
nonetheless people have been able to write this --- without any tricks
like double-quotes --- for a mighty long time. So I now agree that
we shouldn't forbid it. Done at

https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=2955c2be79b35fa369c83fa3b5f44661cb88afa9

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message long Allen 2021-06-03 09:11:40 windows psql connection error
Previous Message Robert Sosinski 2021-06-02 22:20:03 Re: BUG #17045: 14 Beta Tighten up allowed names for custom GUC parameters breaks PostgREST