Re: fix windows contrib compile warnings for redefined

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fix windows contrib compile warnings for redefined
Date: 2004-10-21 19:50:45
Message-ID: 23175.1098388245@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> I didn't. In one case (IDIGNORE) I changed the name of the macro to
> avoid the conflict, and in the other (V_UKNOWN) I removed the Windows
> def which has no applicability in that context (the Windows version
> comes from oleauto.h). Both of these cases occur in .c files and have
> no effects outside these files.

I hadn't checked closely enough --- you're right these are ok.
Patch applied (and yes, tsearch2 does still work for me...)

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message David Fetter 2004-10-22 04:26:39 Example of function returning SETOF RECORD
Previous Message Tom Lane 2004-10-21 18:41:27 Re: fix windows contrib compile warnings for redefined macros