Re: pg_regress: stat correct paths

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jorgen Austvik <Jorgen(dot)Austvik(at)Sun(dot)COM>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: pg_regress: stat correct paths
Date: 2007-11-26 17:42:21
Message-ID: 23145.1196098941@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Jorgen Austvik <Jorgen(dot)Austvik(at)Sun(dot)COM> writes:
> But if we have set srcdir, the directory we are stat'ing, is not the
> same directory that we are reading the files from:

Ah. The reason this works in VPATH mode is that setup of the build tree
duplicated all subdirectories of the source tree, so ./input/ should
exist iff $srcdir/input/ does. I agree it's a bit ugly though; it'd
be better to stat what we really plan to read.

Maybe push the stat operation inside convert_sourcefiles_in ?

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Jorgen Austvik 2007-11-26 17:48:52 Re: pg_regress: stat correct paths
Previous Message Jorgen Austvik 2007-11-26 17:27:29 Re: pg_regress: stat correct paths