"Pavan Deolasee" <pavan(dot)deolasee(at)gmail(dot)com> writes:
> On 1/27/07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> It looks to me that you have introduced a buffer leak into
>> heap_get_latest_tid ...
> I can't spot that.
No, you're right, my apologies. I was thinking that the patch ought to
introduce an UnlockReleaseBuffer after the loop, but that's not
necessary given the calls before all the breaks. (OTOH it might be
cleaner to refactor things that way, if we were going to apply this.
I still don't think heap_get_latest_tid is worth any optimization
regards, tom lane
In response to
pgsql-patches by date
|Next:||From: Tom Lane||Date: 2007-01-27 21:19:16|
|Subject: Re: Change draft gmake control |
|Previous:||From: Tom Lane||Date: 2007-01-27 21:10:18|
|Subject: Re: minor regression test refactor |