From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net> |
Subject: | Re: pgsql: Add 'basebackup_to_shell' contrib module. |
Date: | 2022-03-30 16:58:26 |
Message-ID: | 230838.1648659506@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2022-03-30 12:34:34 -0400, Tom Lane wrote:
>> One refinement that comes to mind as I look at the patch is to distinguish
>> between "check" and "installcheck". Not sure that's worthwhile, but not
>> sure it isn't, either.
> As it's just about "free" to do so, I see no reason not to go for showing that
> difference. How about:
> echo "+++ (tap|regress|isolation) [install-]check in $(subdir) +++" && \
WFM.
> I see no reason to distinguish the PGXS / non-PGXs tap installcheck cases?
Agreed.
> Random aside: Am I the only one bothered by a bunch of places in
> Makefile.global.in quoting like
> $(MAKE) -C '$(top_builddir)' DESTDIR='$(abs_top_builddir)'/tmp_install install >'$(abs_top_builddir)'/tmp_install/log/install.log 2>&1
> and
> rm -rf '$(CURDIR)'/tmp_check &&
> etc
Don't we need that to handle, say, build paths with spaces in them?
Admittedly we're probably not completely clean for such paths,
but that's not an excuse to break the places that do it right.
(I occasionally think about setting up a BF animal configured
like that, but haven't tried yet.)
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2022-03-30 17:04:21 | Re: pgsql: Add 'basebackup_to_shell' contrib module. |
Previous Message | Andres Freund | 2022-03-30 16:54:50 | Re: pgsql: Add 'basebackup_to_shell' contrib module. |
From | Date | Subject | |
---|---|---|---|
Next Message | Dagfinn Ilmari Mannsåker | 2022-03-30 17:00:42 | Re: multithreaded zstd backup compression for client and server |
Previous Message | Robert Haas | 2022-03-30 16:57:35 | Re: basebackup/lz4 crash |