| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | BharatDB <bharatdbpg(at)gmail(dot)com> |
| Cc: | torsten(dot)rupp(at)gmx(dot)net, pgsql-bugs(at)lists(dot)postgresql(dot)org, michael(at)paquier(dot)xyz, VASUKI M <vasukim1992002(at)gmail(dot)com> |
| Subject: | Re: BUG #19095: Test if function exit() is used fail when linked static |
| Date: | 2025-11-12 06:38:47 |
| Message-ID: | 2305435.1762929527@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
BharatDB <bharatdbpg(at)gmail(dot)com> writes:
>> [1]Changing the grep pattern to match the exact symbol ('grep -x exit')
>> prevents such false positives.
We might as well remove the test entirely as do that; it would
fail to detect "_exit" for example.
Additionally, I don't have a lot of faith in "grep -x" being
universally portable. POSIX 2018 does specify that switch, but
it mentions that it is "historically available only with fgrep".
Personally I'm okay with whitelisting pthread_exit() as
Torsten suggested.
BTW, it looks like libpq's meson.build is missing this check.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2025-11-12 07:04:05 | Re: BUG #19106: Potential regression with CTE materialization planning in Postgres 18 |
| Previous Message | Haiyang Li | 2025-11-12 06:35:22 | Re: BUG #19109: catalog lookup with the wrong snapshot during logical decoding causes coredump |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2025-11-12 06:47:33 | Re: Extended Statistics set/restore/clear functions. |
| Previous Message | Chao Li | 2025-11-12 05:58:09 | Re: [PATCH] Add pg_get_subscription_ddl() function |