Re: test/modules/test_oat_hooks vs. debug_discard_caches=1

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Subject: Re: test/modules/test_oat_hooks vs. debug_discard_caches=1
Date: 2022-11-19 01:04:40
Message-ID: 2304165.1668819880@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2022-11-18 15:55:34 -0500, Tom Lane wrote:
>> The test_oat_hooks test is failing --- it's not crashing, but
>> it's emitting more NOTICE lines than the expected output includes,
>> evidently as a result of the hooks getting invoked extra times
>> during cache reloads. I can reproduce that here.

> Did you already look into where those additional namespace searches are coming
> from? There are case in which it is not unproblematic to have repeated
> namespace searches due to the potential for races it opens up...

I'm not sufficiently interested in that API to dig hard for details,
but in a first look it seemed like the extra reports were coming
from repeated executions of recomputeNamespacePath, which are
forced after a cache invalidation by NamespaceCallback.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-11-19 01:05:53 Re: Assertion failure in SnapBuildInitialSnapshot()
Previous Message Alexander Korotkov 2022-11-19 01:02:04 Re: Allow placeholders in ALTER ROLE w/o superuser