Re: backup manifests

From: tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Suraj Kharage <suraj(dot)kharage(at)enterprisedb(dot)com>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Tels <nospam-pg-abuse(at)bloodgate(dot)com>, David Steele <david(at)pgmasters(dot)net>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>
Subject: Re: backup manifests
Date: 2020-03-13 13:53:03
Message-ID: 22efd17f-e647-2b23-c5d4-350a24e4625b@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 3/12/20 8:16 PM, tushar wrote:
>> Seems like expected behavior to me. We could consider providing a more
>> descriptive error message, but there's now way for it to work.
>
> Right , Error message need to be more user friendly .

One scenario which i feel - should error out  even if  -s option is
specified.

create  base  backup directory ( ./pg_basebackup data1)
Connect to root user and take out  the permission from pg_hba.conf file
( chmod 004 pg_hba.conf)

run pg_validatebackup -

[centos(at)tushar-ldap-docker bin]$ ./pg_validatebackup data1
pg_validatebackup: error: could not open file "pg_hba.conf": Permission
denied

run pg_validatebackup  with switch -s

[centos(at)tushar-ldap-docker bin]$ ./pg_validatebackup data1 -s
pg_validatebackup: backup successfully verified

here file is not accessible so i think - it should throw you an error (
the same above one) instead of   blindly skipping it.

--
regards,tushar
EnterpriseDB https://www.enterprisedb.com/
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2020-03-13 14:09:16 Re: bitmaps and correlation
Previous Message Dilip Kumar 2020-03-13 13:32:40 Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager