Re:Re: Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row

From: "Yi Ding" <dingyi_yale(at)163(dot)com>
To: "Fujii Masao" <masao(dot)fujii(at)gmail(dot)com>
Cc: "Peter Eisentraut" <peter(at)eisentraut(dot)org>, "jian he" <jian(dot)universality(at)gmail(dot)com>, "Matheus Alcantara" <matheusssilv97(at)gmail(dot)com>, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, "Masahiko Sawada" <sawada(dot)mshk(at)gmail(dot)com>, "vignesh C" <vignesh21(at)gmail(dot)com>, "Jim Jones" <jim(dot)jones(at)uni-muenster(dot)de>, "Kirill Reshke" <reshkekirill(at)gmail(dot)com>, "Fujii Masao" <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, "Yugo NAGATA" <nagata(at)sraoss(dot)co(dot)jp>, "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re:Re: Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row
Date: 2026-03-16 02:39:21
Message-ID: 2291919f.2a51.19cf483243a.Coremail.dingyi_yale@163.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At 2026-03-13 21:50:07, "Fujii Masao" <masao(dot)fujii(at)gmail(dot)com> wrote:
>On Fri, Mar 13, 2026 at 2:51 PM Yi Ding <dingyi_yale(at)163(dot)com> wrote:
>> The new test added in v1 makes sense to me. A small suggestion is that to verify if a field is really null, we can do:
>>
>> ALTER FOREIGN TABLE agg_bad OPTIONS (ADD on_error 'set_null');
>> SELECT a, b IS NULL FROM agg_bad;
>
>Since the file_fdw test runs "\pset null _null_", a NULL value is displayed as
>"_null_". So you can verify that the value is NULL by checking whether
>"_null_" is shown.
>
>One could argue that this cannot be distinguished from the literal text value
>"_null_". However, relying on "\pset null _null_" is sufficient for this test,
>I think.
>
>Regards,
>
>--
>Fujii Masao

>

Sounds reasonable,that addressed my comment.

Regards,
Yi Ding

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Xuneng Zhou 2026-03-16 03:05:42 Re: Streamify more code paths
Previous Message Japin Li 2026-03-16 02:31:23 Re: Use SMgrRelation instead of SMgrRelationData * in pgaio_io_set_target_smgr()