Re: pgsql: Add support for temporary replication slots

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add support for temporary replication slots
Date: 2016-12-12 19:32:57
Message-ID: 22907.1481571177@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> writes:
> Yes you are correct, we tried naively to first drop another slot in
> hopes that it will give the other backend enough time to close, but
> apparently that wasn't robust enough for slower machines.

> Attached is the fixed test using the loop from test_extensions (and yes
> I would have missed the pg_stat_clear_snapshot() call without the hint,
> thanks :) ).

Pushed, thanks.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-12-12 19:41:54 pgsql: Catversion bump for temporary replication slots.
Previous Message Tom Lane 2016-12-12 19:32:27 pgsql: Fix race condition in test_decoding "slot" test.

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2016-12-12 19:42:54 Re: Nested Wait Events?
Previous Message Peter Geoghegan 2016-12-12 19:30:02 Re: tuplesort_gettuple_common() and *should_free argument