Re: show Heap Fetches in EXPLAIN for index-only scans

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: show Heap Fetches in EXPLAIN for index-only scans
Date: 2012-01-13 16:24:29
Message-ID: 22897.1326471869@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> So here's a 5-line patch that adds the number of heap fetches to the
> EXPLAIN ANALYZE output. This might not be all the instrumentation
> we'll ever want here, but I think we at least want this much.

Cosmetic gripes:

1. Please initialize the counter in ExecInitIndexOnlyScan. We don't
generally rely on node fields to init as zeroes.

2. Project style is to use foo++, not ++foo, in contexts where
it doesn't actually matter which is used.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2012-01-13 16:44:26 Re: Postgres ReviewFest Patch: URI connection string support for libpq
Previous Message Simon Riggs 2012-01-13 16:13:46 Re: Disabled features on Hot Standby