Re: relcache leak warnings vs. errors

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: relcache leak warnings vs. errors
Date: 2020-04-11 14:54:49
Message-ID: 22890.1586616889@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> How about a compile-time option to turn all the warnings in resowner.c
> into errors? This could be enabled automatically by --enable-cassert,
> similar to other defines that that option enables.

[ itch... ] Those calls occur post-commit; throwing an error there
is really a mess, which is why it's only WARNING now.

I guess you could make them PANICs, but it would be an option that nobody
could possibly want to have enabled in anything resembling production.
So I"m kind of -0.5 on making --enable-cassert do it automatically.
Although I suppose that it's not really worse than other assertion
failures.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message wenjing 2020-04-11 15:05:17 Re: [bug] Wrong bool value parameter
Previous Message wenjing 2020-04-11 14:54:38 Re: [bug] Wrong bool value parameter