| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Add EXTRA_CFLAGS to configure |
| Date: | 2015-10-28 15:59:29 |
| Message-ID: | 22885.1446047969@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2015-10-28 11:42:28 -0400, Tom Lane wrote:
>> 1. Invent a "--with-werror" configure switch that causes -Werror to be
>> added to the CFLAGS, but not while running tests that it'd break.
>>
>> 2. Explicitly filter -Werror out of the user-provided CFLAGS while running
>> tests that it'd break.
> I think either of these is fine - I've a slight preference for 2)
> because we already filter *FLAGS in a bunch of places and it seems a bit
> nicer to extend, should another similar case come up.
> Do you have a preference?
I'd go with #2 also, if it's not hard to implement. Single-purpose
configure switches are a wart.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christopher Browne | 2015-10-28 16:24:31 | Re: quieting DEBUG3 |
| Previous Message | Michael Paquier | 2015-10-28 15:57:36 | Re: pageinspect patch, for showing tuple data |