Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.

Alex Hunsaker <badalex(at)gmail(dot)com> writes:
> Oh my... I dunno exactly what I was smoking last night, but its a good
> thing I didn't share :-). Uh so my test program was also completely
> wrong, Ill have to redo it all. I've narrowed it down to:
> if ((type == SVt_PVGV || SvREADONLY(sv)))
> {
> if (type != SVt_PV &&
> type != SVt_NV)
> {
> sv = newSVsv(sv);
> }
> }

Has anyone tried looking at the source code for SvPVutf8 to see exactly
what cases it fails on? The fact that there's an explicit croak() call
makes me think it might not be terribly hard to tell.

regards, tom lane