Re: pgsql: Allow a partitioned table to have a default partition.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Allow a partitioned table to have a default partition.
Date: 2017-09-08 22:50:26
Message-ID: 22870.1504911026@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> On Sat, Sep 9, 2017 at 10:23 AM, Thomas Munro
> <thomas(dot)munro(at)enterprisedb(dot)com> wrote:
>> map_partition_varattnos() doesn't always write to *found_whole_row, so
>> it's uninitialised here in generate_partition_qual():

That was the first thing I thought of ...

> Hmm, no. I take that back.

... and I looked at map_variable_attnos and decided it was fine, too.

But it ain't. It's failing on empty partition expressions, and there's
a short-circuit exit from map_partition_varattnos.

Will fix.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-09-08 23:04:39 pgsql: Fix uninitialized-variable bug.
Previous Message Thomas Munro 2017-09-08 22:36:35 Re: pgsql: Allow a partitioned table to have a default partition.