Re: htup header reorganization breaks many extension modules

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Albe Laurenz" <laurenz(dot)albe(at)wien(dot)gv(dot)at>
Cc: "Hitoshi Harada *EXTERN*" <umi(dot)tanuki(at)gmail(dot)com>, "Peter Eisentraut" <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: htup header reorganization breaks many extension modules
Date: 2012-09-26 14:07:24
Message-ID: 22807.1348668444@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Albe Laurenz" <laurenz(dot)albe(at)wien(dot)gv(dot)at> writes:
> Hitoshi Harada wrote:
>> But it's only add #include "access/htup_details.h"? I'd not argue
>> it's harmful unless I missed your point.

> I guess the point is that you need an #ifdef if you want a module
> to be able to build with both 9.3 and lower versions.

I can't get excited about this either. This isn't the first, or the
last, change that add-on modules can expect to have to make to track
newer Postgres versions. If we allow Peter's complaint to become the
new project policy, we'll never be able to make any header
rearrangements at all, nor change any internal APIs.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2012-09-26 14:08:39 Re: Oid registry
Previous Message Tom Lane 2012-09-26 14:02:21 Re: system_information.triggers & truncate triggers