Re: SQL/JSON features for v15

From: "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>, Amit Langote <amitlangote09(at)gmail(dot)com>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
Subject: Re: SQL/JSON features for v15
Date: 2022-08-31 14:20:24
Message-ID: 2276d20d-43ff-f9f6-5c9c-c2875739e66c@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 8/31/22 8:38 AM, Andrew Dunstan wrote:
>
> On 2022-08-31 We 07:01, Amit Langote wrote:
>> On Wed, Aug 31, 2022 at 3:51 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
>>> SELECT JSON_VALUE(jsonb '"aaa"', '$' RETURNING int DEFAULT 111 ON ERROR);
>>> - json_value
>>> -------------
>>> - 111
>>> -(1 row)
>>> -
>>> +ERROR: syntax error at or near "DEFAULT"
>>> +LINE 1: ...ELECT JSON_VALUE(jsonb '"aaa"', '$' RETURNING int DEFAULT 11...
>>>
>>> Is it intentional that you left many instances of the regression test
>>> output changes like the above?
>> Actually, thinking more about this, I am wondering if we should not
>> remove the DEFAULT expression productions in gram.y. Maybe we can
>> keep the syntax and give an unsupported error during parse-analysis,
>> like the last version of the patch did for DEFAULT ON EMPTY. Which
>> also means to also leave JsonBehavior alone but with default_expr
>> always NULL for now.
>>
>
> Producing an error in the parse analysis phase seems best to me.

Andres, Robert, Tom: With this recent work, have any of your opinions
changed on including SQL/JSON in v15?

Thanks,

Jonathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2022-08-31 14:41:24 Re: pg_upgrade generated files in subdir follow-up
Previous Message Dagfinn Ilmari Mannsåker 2022-08-31 14:19:50 Re: plpgsql-trigger.html: Format TG_ variables as table (patch)