| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Convert wal_sync_method to guc enum. |
| Date: | 2008-05-12 17:35:35 |
| Message-ID: | 22736.1210613735@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> I need to leave for a couple of hours, will look again when I get back.
> But so far, I'm quite surprised. Here's my reasoning, please poke holes
> in it :-)
I think you forgot to handle SYNC_METHOD_OPEN_DSYNC in issue_xlog_fsync.
If you are going to split SYNC_METHOD_OPEN into two codes, you need to
handle both those codes everywhere SYNC_METHOD_OPEN was formerly
referenced ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2008-05-12 19:04:25 | Re: pgsql: Report which WAL sync method we are trying to change *to* when it |
| Previous Message | Michael Meskes | 2008-05-12 16:30:17 | pgsql: Check for non-existant connection in prepare statement handling. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Brendan Jurd | 2008-05-12 17:41:56 | Re: Syntax decisions for pl/pgsql RAISE extension |
| Previous Message | Kevin Grittner | 2008-05-12 17:33:45 | Re: Syntax decisions for pl/pgsql RAISE extension |