| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me> |
| Subject: | Re: pgindent && weirdness |
| Date: | 2020-02-17 23:42:20 |
| Message-ID: | 22726.1581982940@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> Another problem is that there is one thing in our tree that looks like
> a non-cast under the new rule, but it actually expands to a type name,
> so now we get that wrong! (I mean, unpatched indent doesn't really
> understand it either, it thinks it's a cast, but at least it knows the
> following * is not a binary operator):
> - STACK_OF(X509_NAME) *root_cert_list = NULL;
> + STACK_OF(X509_NAME) * root_cert_list = NULL;
> That's a macro from an OpenSSL header. Not sure what to do about that.
If we get that wrong, but a hundred other places look better,
I'm not too fussed about it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-02-17 23:56:03 | Re: more ALTER .. DEPENDS ON EXTENSION fixes |
| Previous Message | Alvaro Herrera | 2020-02-17 23:30:04 | Re: Error on failed COMMIT |