From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
Cc: | Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Move regression.diffs of pg_upgrade test suite |
Date: | 2018-12-26 22:02:37 |
Message-ID: | 22708.1545861757@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> On 12/23/18 10:44 PM, Noah Misch wrote:
>> A disadvantage of any change here is that it degrades buildfarm reports, which
>> recover slowly as owners upgrade to a fixed buildfarm release. This will be
>> similar to the introduction of --outputdir=output_iso. On non-upgraded
>> animals, pg_upgradeCheck failures will omit regression.diffs.
>>
>> I think the right fix, attached, is to use "pg_regress --outputdir" to
>> redirect these files to src/bin/pg_upgrade/tmp_check/regress.
> Seems reasonable.
Do we need to change anything in the buildfarm client to improve its
response to this? If so, seems like it might be advisable to make a
buildfarm release with the upgrade before committing the change.
Sure, not all owners will update right away, but if they don't even
have the option then we're not in a good place.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2018-12-26 22:09:05 | Re: [HACKERS] PATCH: multivariate histograms and MCV lists |
Previous Message | Tom Lane | 2018-12-26 21:55:14 | Re: Small doc tweak for array/string functions |