| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Prashant Chinnam <crprashant(at)hotmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, surya poondla <suryapoondla4(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Takeshi Ideriha <iderihatakeshi(at)gmail(dot)com> |
| Subject: | Re: Return INT_MAX or INT_MIN from strtoint() on overflow |
| Date: | 2026-10-30 02:12:07 |
| Message-ID: | 2262966.1793326327@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Prashant Chinnam <crprashant(at)hotmail(dot)com> writes:
> On patch [1]: I intend to keep strtoi64() there even if
> this lands, because the pgcrypto fix is meant to be
> backpatched to REL_18_STABLE, where strtoint() keeps its
> current behavior, while strtoi64() behaves the same on
> both branches. Happy to follow a different direction if
> committers prefer otherwise.
My thought here is to back-patch the strtoint() change.
I cannot envision any case that that would make worse.
And failing to do so leaves a land-mine for potential
future back-patches of code using strtoint().
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shihao zhong | 2026-10-30 02:18:57 | Re: Parallel autovacuum: leader crashes when no DSM segment can be created |
| Previous Message | Prashant Chinnam | 2026-10-30 02:06:02 | Re: Return INT_MAX or INT_MIN from strtoint() on overflow |