Skip site navigation (1) Skip section navigation (2)

Re: BTree vacuum before page splitting

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Junji TERAMOTO <teramoto(dot)junji(at)lab(dot)ntt(dot)co(dot)jp>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: BTree vacuum before page splitting
Date: 2006-01-27 15:16:57
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
Junji TERAMOTO <teramoto(dot)junji(at)lab(dot)ntt(dot)co(dot)jp> writes:
> This patch adds a function to remove unnecessary items before split
> page of BTree.

> When a new item is put in the page, it looks for the "LP_DELETE" item,
> and removes that item.

I think this is quite likely to break things :-(.  What sort of
conditions have you tested it under?  (If this were safe, we'd
not have invented the LP_DELETE flag to begin with, but just have
deleted known-dead items immediately.)

BTW, a patch that makes major changes in the behavior of a function
and doesn't update the code comments is unacceptable.  The comments
are as important as the code, if not more so, because other people
are going to have to read this after you.

			regards, tom lane

In response to


pgsql-patches by date

Next:From: Thomas HallgrenDate: 2006-01-27 15:29:32
Subject: Re: Adding a --quiet option to initdb
Previous:From: Tom LaneDate: 2006-01-27 15:09:00
Subject: Re: Adding a --quiet option to initdb

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group