| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Pierre Forstmann <pierre(dot)forstmann(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Reduce logging during prepared transaction recovery |
| Date: | 2026-10-29 23:45:44 |
| Message-ID: | 2256937.1793317544@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
> Thanks for updating the patch! LGTM.
> I've pushed it. Thanks!
BF member prion has been failing since this went in. It looks like
the cause is that it's configured for log_error_verbosity = verbose,
so that what it prints is like
# 2026-10-29 20:10:30.831 UTC [501077:43] LOG: 00000: recovered 1 prepared transaction
# 2026-10-29 20:10:30.831 UTC [501077:44] LOCATION: RecoverPreparedTransactions, twophase.c:2212
but the new test cases are not expecting a SQLSTATE in there:
log_like => [qr/LOG: recovered 1 prepared transaction\r?$/m],
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2026-10-30 00:05:14 | Re: [PATCH] pgstat: Add helper to drop entries from a stats kind's hash |
| Previous Message | Lukas Fittl | 2026-10-29 23:40:49 | Re: Use instr_time for pg_stat_database block read/write time counters |