Re: pgsql: libpq: change PQconndefaults() to ignore invalid service files

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: libpq: change PQconndefaults() to ignore invalid service files
Date: 2013-12-03 16:30:15
Message-ID: 22481.1386088215@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> libpq: change PQconndefaults() to ignore invalid service files
> Previously missing or invalid service files returned NULL. Also fix
> pg_upgrade to report "out of memory" for a null return from
> PQconndefaults().

Why does this patch remove the errorMessage argument from
pg_fe_getauthname? I gauge the amount of thought that went into
that choice by the fact that the comment wasn't updated.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2013-12-03 16:33:52 pgsql: Update C comment for pg_fe_getauthname
Previous Message Bruce Momjian 2013-12-03 16:12:46 pgsql: libpq: change PQconndefaults() to ignore invalid service files

Browse pgsql-hackers by date

  From Date Subject
Next Message Claudio Freire 2013-12-03 16:32:47 Re: Parallel Select query performance and shared buffers
Previous Message Bruce Momjian 2013-12-03 16:25:56 Re: 9.2.1 & index-only scans : abnormal heap fetches after VACUUM FULL