From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Remembering bug #6123 |
Date: | 2012-01-12 16:30:35 |
Message-ID: | 22481.1326385835@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
"Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> writes:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Also, what's the point of testing update_ctid? I don't see that
>> it matters whether the outdate was a delete or an update.
> The update_ctid code was a carry-over from my old, slightly
> different approach, which I failed to change as I should have. I'll
> fix that along with the other.
Actually, on reflection there might be a reason for checking
update_ctid, with a view to allowing "harmless" cases. I see
these cases:
* UPDATE finds a trigger already updated the row: must throw error
since we can't apply the update.
* UPDATE finds a trigger already deleted the row: arguably, we could
let the deletion stand and ignore the update action.
* DELETE finds a trigger already updated the row: must throw error
since we can't apply the delete.
* DELETE finds a trigger already deleted the row: arguably, there's
no reason to complain.
Don't know if that was your reasoning as well. But if it is, then again
the comment needs to cover that.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2012-01-12 16:33:26 | Re: Remembering bug #6123 |
Previous Message | Andrew Dunstan | 2012-01-12 16:28:10 | Re: JSON for PG 9.2 |