| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: [BUGS] BUG #4680: Server crashed if using wrong (mismatch) conversion functions |
| Date: | 2009-03-02 19:45:24 |
| Message-ID: | 22477.1236023124@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> Looks ok to me. I'm still a bit uneasy about the assumption that the
> error message is 7-bit ACII. Maybe that's just because I don't fully
> understand all the conditions how we can end up in recursion, so I would
> still put something into pq_send_raw_string to check that the string
> really is 7-bit ASCII. Just in case. Maybe clear all the high bits, or
> replace non-ASCII characters with question marks.
Throwing an error is not the answer --- we only get here after we've
already failed to do that, repeatedly. But it's certainly not a path
that requires high performance, so I have no problem with the
replace-non-ascii-with-question-mark idea. Will make it so.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jaime Casanova | 2009-03-03 04:52:42 | Re: BUG #4684: lastval in function |
| Previous Message | Heikki Linnakangas | 2009-03-02 19:37:17 | Re: [BUGS] BUG #4680: Server crashed if using wrong (mismatch) conversion functions |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2009-03-02 20:02:35 | Re: GIN, partial matches, lossy bitmaps |
| Previous Message | Robert Treat | 2009-03-02 19:44:34 | sanity check on max_fsm_relations |