Re: Re: [COMMITTERS] TOAST

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jan Wieck <JanWieck(at)Yahoo(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] TOAST
Date: 2000-07-04 02:19:52
Message-ID: 2245.962677192@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

JanWieck(at)t-online(dot)de (Jan Wieck) writes:
> Hmmm - with my latest changes I get the same, without them I
> don't. Will backout the changes if I cannot find it quickly.

The problem appears to be that DataFill() is invoked on the tuple
after toasting, and it forces the infomask to zero, losing any
transaction status bits that may have been there. I think perhaps
line 93 of heaptuple.c should be

*infomask &= HEAP_XACT_MASK;

not

*infomask = 0;

Comments anyone?

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2000-07-04 02:40:56 pgsql/src/backend/access/common (heaptuple.c)
Previous Message Vadim B. Mikheev - CVS 2000-07-04 01:49:47 pgsql/src/include/storage (itemptr.h)

Browse pgsql-hackers by date

  From Date Subject
Next Message The Hermit Hacker 2000-07-04 02:41:29 Re: [HACKERS] proposed improvements to PostgreSQL license
Previous Message Philip Warner 2000-07-04 02:13:12 Re: [HACKERS] proposed improvements to PostgreSQL license