| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pgindent vs variable declaration across multiple lines |
| Date: | 2023-01-24 15:33:35 |
| Message-ID: | 2242842.1674574415@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 2023-01-22 Su 17:34, Tom Lane wrote:
>> I've also attached a diff
>> representing the delta between what current pg_bsd_indent wants to do
>> to HEAD and what this would do. All the changes it wants to make look
>> good, although I can't say whether there are other places it's failing
>> to change that we'd like it to.
> Changes look good. There are a handful of places where I think the code
> would be slightly more readable if a leading typecast were moved to the
> second line.
Possibly, but that's the sort of decision that pgindent leaves to human
judgment I think. It'll reflow comment blocks across lines, but I don't
recall having seen it move line breaks within code.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2023-01-24 15:46:28 | Re: old_snapshot_threshold bottleneck on replica |
| Previous Message | Tom Lane | 2023-01-24 15:30:42 | Re: Making Vars outer-join aware |