Re: pg_restore loops forever past EOF for corrupt custom archive files

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Chad Wagner" <chad(dot)wagner(at)gmail(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: pg_restore loops forever past EOF for corrupt custom archive files
Date: 2007-08-05 16:35:41
Message-ID: 22424.1186331741@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

"Chad Wagner" <chad(dot)wagner(at)gmail(dot)com> writes:
> This patch modifies the ReadStr function in pg_backup_archiver.c to validate
> the result of *AH->ReadBufPtr matches the value of l.

If we're trying to defend against premature EOF, this hardly seems like
a sufficient patch.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Chad Wagner 2007-08-05 17:18:36 Re: pg_restore loops forever past EOF for corrupt custom archive files
Previous Message Chad Wagner 2007-08-05 02:38:31 pg_restore loops forever past EOF for corrupt custom archive files