Re: Header checking failures on LLVM-less machines

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Header checking failures on LLVM-less machines
Date: 2019-01-29 03:19:32
Message-ID: 22407.1548731972@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> I don't think we are actually contradicting each other. The aim of that
> error was to prevent pieces of code that aren't conditional on
> --with-llvm from including llvmjit.h. I was, for a moment and wrongly,
> thinking that we could style the header in a way that'd make it both for
> safe for cpluspluscheck and still error in that case, but that was a
> brainfart. But even leaving that brainfart aside, I'm not arguing
> against adding those include guards, so ...?

Works for me now. Thanks for fixing.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-01-29 03:23:36 Re: Why are we PageInit'ing buffers in RelationAddExtraBlocks()?
Previous Message Kyotaro HORIGUCHI 2019-01-29 03:18:29 Re: pg_stat_ssl additions