| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Unused header file inclusion |
| Date: | 2019-07-31 13:42:44 |
| Message-ID: | 22397.1564580564@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Wed, Jul 31, 2019 at 11:55:37AM +0530, Amit Kapila wrote:
>> If we can come up with some such tool, we might be able to integrate
>> it with Thomas's patch tester [1] wherein it can apply the patch,
>> verify if there are unnecessary includes in the patch and report the
>> same.
> Or even get something into src/tools/? If the produced result is
> clean enough, that could be interesting.
I take it nobody has actually bothered to *look* in src/tools.
src/tools/pginclude/README
Note that our experience with this sort of thing has not been very good.
See particularly 1609797c2.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sehrope Sarkuni | 2019-07-31 13:43:00 | Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS) |
| Previous Message | Fabien COELHO | 2019-07-31 13:40:04 | Re: proposal - patch: psql - sort_by_size |