| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Emre Hasegeli <emre(at)hasegeli(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Improve geometric types |
| Date: | 2018-07-29 15:11:46 |
| Message-ID: | 222e794a-9c76-21cb-e7db-2043e31d9b9c@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07/29/2018 04:31 PM, Jeff Janes wrote:
>
>
> On Sat, Jul 28, 2018 at 9:54 PM, Tomas Vondra
> <tomas(dot)vondra(at)2ndquadrant(dot)com <mailto:tomas(dot)vondra(at)2ndquadrant(dot)com>> wrote:
>
>
>
> I've committed the first two parts, after a review and testing.
>
>
> I'm getting a compiler warning now:
>
> geo_ops.c: In function 'line_closept_point':
> geo_ops.c:2528:7: warning: variable 'retval' set but not used
> [-Wunused-but-set-variable]
> bool retval;
>
Yeah, the variable is apparently only used in an assert. Will fix.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2018-07-29 15:14:55 | Re: [PATCH] Improve geometric types |
| Previous Message | Michael Paquier | 2018-07-29 14:59:32 | Re: pgsql: Refactor geometric functions and operators |