Re: Solaris "sed" versus pre-v13 plpython tests

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Noah Misch <noah(at)leadboat(dot)com>, hofstetter(at)jomasoft(dot)ch
Subject: Re: Solaris "sed" versus pre-v13 plpython tests
Date: 2022-09-01 00:57:22
Message-ID: 222938.1661993842@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> I confirmed on the gcc farm's Solaris 11 box that the pattern
> doesn't work as expected with /usr/bin/sed:

> tgl(at)gcc-solaris11:~$ echo except foo, bar: | sed -e 's/except \([[:alpha:]][[:alpha:].]*\), *\([[:alpha:]][[:alpha:]]*\):/except \1 as \2:/g'
> except foo, bar:

> We could perhaps do this instead:

> $ echo except foo, bar: | sed -e '/^ *except.*,.*: *$/s/, / as /g'
> except foo as bar:

> It's a little bit more brittle, but Python doesn't allow any other
> commands on the same line does it?

Oh ... after a bit more experimentation, there's an easier way.
Apparently the real problem is that Solaris' sed doesn't handle
[[:alpha:]] (I wonder if this is locale-dependent?). I get
correct results after expanding it manually, eg

tgl(at)gcc-solaris11:~$ echo except foo, bar: | sed -e 's/except \([a-z][a-z.]*\), *\([a-z][a-zA-Z]*\):/except \1 as \2:/g'
except foo as bar:

We aren't likely to need anything beyond a-zA-Z and maybe 0-9,
so I'll go fix it that way.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-09-01 00:57:23 Re: Support tls-exporter as channel binding for TLSv1.3
Previous Message Justin Pryzby 2022-09-01 00:52:39 Re: pg15b3: recovery fails with wal prefetch enabled