Re: Proposal: More structured logging

From: Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Julien Rouhaud <rjuju123(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Proposal: More structured logging
Date: 2022-01-27 13:58:37
Message-ID: 2227263.ElGaqSPkdT@aivenronan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Le jeudi 27 janvier 2022, 08:15:01 CET Michael Paquier a écrit :
> On Tue, Jan 18, 2022 at 06:46:03AM +0100, Ronan Dunklau wrote:
> > Hum, there was a missing import in csvlog.c from the fix above. Sorry
> > about
> > that.
> +<!-- Don't forget to also update file_fdw.sgml if you change this
> table definition -->
> <programlisting>
> You are also forgetting that the table listing all the jsonlog fields
> needs a refresh with this new key called "tags", and that it has a
> JSON object underneath.


> If you want to test all the formats supported by logging_destination,
> wouldn't this stuff be better if tested through TAP with
> logging_destination set with csvlog, jsonlog and stderr? This is
> lacking coverage for csvlog.c and jsonlog.c, paths touched by your
> patch.

Done, I also added coverage for log_verbosity = verbose while I was at it,
and fixed a bug I introduced in csvlog while rebasing...

Ronan Dunklau

Attachment Content-Type Size
v7-0001-Add-ErrorTag-support.patch text/x-patch 4.0 KB
v7-0002-Output-error-tags-in-CSV-logs.patch text/x-patch 2.7 KB
v7-0003-Add-error-tags-to-json-output.patch text/x-patch 1.9 KB
v7-0004-Add-test-module-for-the-new-tag-functionality.patch text/x-patch 7.8 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2022-01-27 14:59:07 Re: snapper and skink and fairywren (oh my!)
Previous Message Amul Sul 2022-01-27 13:45:34 Re: generalized conveyor belt storage