From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Paul Ramsey <pramsey(at)cleverelephant(dot)ca> |
Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] postgres_fdw extension support |
Date: | 2015-07-21 18:22:02 |
Message-ID: | 22258.1437502922@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Paul Ramsey <pramsey(at)cleverelephant(dot)ca> writes:
> On July 21, 2015 at 11:07:36 AM, Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> I'm inclined to think that it's not really necessary to worry about
> invalidating a per-connection cache of "is this function safe to ship"
> determinations.
> So: yes to a local cache of all forwardable functions/ops, populated in full the first time through (does that speak maybe to using a binary search on a sorted list instead of a hash, since I only pay the sort price once and am not doing any insertions?). And then we just hold it until the connection goes away.
No, *not* populated first-time-through, because that won't handle any of
the CREATE, DROP, or UPGRADE cases. It's also doing a lot of work you
might never need. I was thinking of "populate on demand", that is, first
time you need to know whether function X is shippable, you find that out
and then cache the answer (whether it be positive or negative).
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Todd A. Cook | 2015-07-21 18:24:47 | Re: WAL logging problem in 9.4.3? |
Previous Message | Paul Ramsey | 2015-07-21 18:14:55 | Re: [PATCH] postgres_fdw extension support |