| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>, Bernd Helmle <mailings(at)oopsware(dot)de>, pgsql-hackers(at)postgresql(dot)org, Thom Brown <thombrown(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Subject: | Re: [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns |
| Date: | 2010-02-02 02:32:01 |
| Message-ID: | 22237.1265077921@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com> writes:
> (2010/02/02 11:09), Tom Lane wrote:
>> KaiGai Kohei<kaigai(at)ak(dot)jp(dot)nec(dot)com> writes:
>>> The attached one also clean up ATPrepAddColumn() and ATExecAddColumn() code,
>>> not only ATPrepAlterColumnType(), according to what I mentioned above.
>>
>> What exactly do you claim is wrong with the ADD COLUMN case?
> ADD COLUMN case works correctly, but it takes unnecessary loops,
> because the find_all_inheritors() didn't provide the value to be
> set on the new pg_attribute.attinhcount.
> I'm saying it can be rewritten in more graceful manner using the
> new expected_parents argument.
I tend to think that if it ain't broke don't fix it; the odds of
actually breaking it are too high. I don't really find the new coding
more graceful, anyway ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | KaiGai Kohei | 2010-02-02 02:39:07 | Re: [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns |
| Previous Message | Robert Haas | 2010-02-02 02:31:01 | Re: [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns |