| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Identity columns |
| Date: | 2017-04-06 14:24:45 |
| Message-ID: | 22227.1491488685@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Identity columns
This commit is causing a compiler warning for me:
tablecmds.c: In function 'ATExecSetIdentity':
tablecmds.c:5936: warning: 'address.objectSubId' may be used uninitialized in this function
tablecmds.c:5936: warning: 'address.objectId' may be used uninitialized in this function
I'm not sure why it's not complaining about all three fields, because
AFAICS, the function returns a totally undefined ObjectAddress when
generatedEl is not set. What is the intention there? (If the function
were adequately documented, maybe I could divine that for myself, but
heaven help the reader who would like to know what this function is
supposed to do.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2017-04-06 14:32:24 | pgsql: Always SnapshotResetXmin() during ClearTransaction() |
| Previous Message | Tom Lane | 2017-04-06 14:12:50 | Re: pgsql: Avoid SnapshotResetXmin() during AtEOXact_Snapshot() |