| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: debug log in pg_archivecleanup |
| Date: | 2010-06-17 17:33:23 |
| Message-ID: | 22143.1276796003@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
> On Wed, Jun 16, 2010 at 12:24 PM, Takahiro Itagaki
> <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> wrote:
>> This is because pg_archivecleanup puts the line break "\n" in the head of
>> debug message. Why should we do so?
> Yes. What about the attached patch?
Applied along with a bit of further editorialization.
>> Note that we don't need a line break at Line 130
>> because strerror() fills the last %s.
>> L.130: fprintf(stderr, "\n%s: ERROR failed to remove \"%s\": %s",
> Right.
Huh? strerror() doesn't include a newline.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-06-17 17:37:52 | Re: Debug message in RemoveOldXlogFiles |
| Previous Message | Andy Balholm | 2010-06-17 16:57:26 | Re: ANNOUNCE list (was Re: New PGXN Extension site) |