| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Spelling change in LLVM 14 API |
| Date: | 2021-08-22 13:22:43 |
| Message-ID: | 2210367.1629638563@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> After [1], seawasp blew up[2]. I tested the following fix on LLVM 13
> and 14 (main branch ~2 days ago). Better ideas welcome.
> - if (F.getAttributes().hasFnAttribute(llvm::Attribute::NoInline))
> +#if LLVM_VERSION_MAJOR < 14
> +#define hasFnAttr hasFnAttribute
> +#endif
> +
> + if (F.getAttributes().hasFnAttr(llvm::Attribute::NoInline))
Seems like either we should push back on pointless renaming, or else
that we're not really supposed to be accessing this non-stable API.
I have no idea which of those situations applies ... but if the LLVM
guys are randomly renaming methods that *are* supposed to be
user-visible, they need re-education.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2021-08-22 13:29:01 | Re: Mark all GUC variable as PGDLLIMPORT |
| Previous Message | Tom Lane | 2021-08-22 13:19:42 | Re: Mark all GUC variable as PGDLLIMPORT |