| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Vladimir Rusinov <vrusinov(at)google(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, David Steele <david(at)pgmasters(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Cynthia Shang <cynthia(dot)shang(at)crunchydata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal |
| Date: | 2017-01-26 18:10:55 |
| Message-ID: | 22098.1485454255@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Stephen Frost <sfrost(at)snowman(dot)net> writes:
> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
>> What I think might be worth considering is inserting underscores,
>> eg "pg_receive_wal", anywhere that we are running the abbreviation
>> directly against another word. We won't get another chance.
> Wouldn't that make it 'pg_recv_wal'? Or were you referring to the 'wal'
> as being the abbreviation?
The latter. As far as the programs go, that would be
pg_receive_wal
pg_reset_wal
pg_wal_dump
The other cases you mention are, for the most part, words that we're
running together ("db" is the only exception) so they're not committing
double sins against readability. Anyway, I'm not suggesting that we
should rename anything this patch isn't touching already.
regards, tom lane
PS: I'm trying hard not to open the can of worms labeled "pg_dump_wal".
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2017-01-26 18:12:21 | Re: Superowners |
| Previous Message | Robert Haas | 2017-01-26 18:09:45 | Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal |