Re: libpq and psql not on same page about SIGPIPE

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, manfred(at)colorfullife(dot)com
Subject: Re: libpq and psql not on same page about SIGPIPE
Date: 2004-12-02 03:31:22
Message-ID: 2205.1101958282@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Yes, that is the logic in my patch, except that I don't check errno, I
> just call sigpending().

No, that's wrong: if there is a pending SIGPIPE that belongs to the
outer app, you'd clear it.

> There are a few writes and it seemed impossible
> to check them all.

Hmm? There is only one place this needs to be done, namely
pqsecure_write.

BTW, have you posted the patch yet or are you still working on it?
The mail server seems a bit flaky today ...

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-12-02 03:45:15 Re: [HACKERS] libpq and psql not on same page about SIGPIPE
Previous Message Michael Fuhr 2004-12-02 03:10:24 Re: New compile warnings for inheritance

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-12-02 03:45:15 Re: [HACKERS] libpq and psql not on same page about SIGPIPE
Previous Message Jon Jensen 2004-12-02 00:52:08 Update for documentation on CVS