"Webb Sprague" <webb(dot)sprague(at)gmail(dot)com> writes:
> execute 'create role ' || $1 || 'LOGIN';
I think you're short one crucial space ...
regards, tom lane