Re: Yet another issue with pg_upgrade vs unix_socket_directories

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Yet another issue with pg_upgrade vs unix_socket_directories
Date: 2012-09-04 18:07:35
Message-ID: 21969.1346782055@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Yeah, I have resorted to putting something like
> export PGHOST=/tmp
> in all my test scripts, because the above-mentioned issues have affected
> Debian for a long time. Welcome to the party. ;-)

Yeah, my current patch for Fedora does exactly that in pg_regress, and
has it force the test postmaster's unix_socket_directory as well.
The problem with pg_upgrade's shell script is that it's not going
through pg_regress: it launches some test postmasters directly, and
also fires up psql etc directly. So it needs its own fix for this.

> It might actually be useful if the postmaster accepted PGHOST as the
> default value for the -k option, just like it accepts PGPORT. Then this
> type setup will become much easier because clients and servers will use
> the same defaults.

Cute idea, but it'll fall down rather badly if PGHOST is a hostname...

There's no time to redesign this stuff for 9.2, but now that I've had
some exposure to the testing difficulties created by a nonstandard
default socket directory, I'm more interested in trying to fix these
issues in core.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2012-09-04 18:25:27 Re: pg_upgrade del/rmdir path fix
Previous Message Bruce Momjian 2012-09-04 18:04:04 Re: Yet another issue with pg_upgrade vs unix_socket_directories