From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | Robert Treat <rob(at)xzilla(dot)net> |
Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_dump/pg_dumpall help synopses and terminology |
Date: | 2025-06-19 12:10:41 |
Message-ID: | 21952d94-53ad-4c6f-91e7-4fce3dc4d092@eisentraut.org |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 18.06.25 22:57, Robert Treat wrote:
> I also wondered why you differentiated SQL script file vs archive in
> the change here:
>
> - of a cluster into an archive. The archive contains
> + of a cluster into an SQL script file or an archive. The output contains
>
> but then did not differentiate them here (I guess it should say SQL
> script files or archives?)
>
> <refpurpose>
> - restore a <productname>PostgreSQL</productname> database or cluster
> - from an archive created by <application>pg_dump</application> or
> + restore <productname>PostgreSQL</productname> databases from archives
> + created by <application>pg_dump</application> or
> <application>pg_dumpall</application>
> </refpurpose>
The second bit is from pg_restore, which does not restore SQL script
files, only archives.
> I don't know if there is an official definition of an archive, but I
> don't tend to think of a single script (like default pg_dumpall) as an
> archive.
I agree.
> Granted, these are just minor tightening up at best; generally +1 to
> the clean up as a whole.
Committed. Thanks for taking a look.
From | Date | Subject | |
---|---|---|---|
Next Message | Jelte Fennema-Nio | 2025-06-19 12:12:23 | Re: BackendKeyData is mandatory? |
Previous Message | Fujii Masao | 2025-06-19 11:53:25 | Re: pg_dump misses comments on NOT NULL constraints |