| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, Dave Page <dpage(at)vale-housing(dot)co(dot)uk>, Andreas Pflug <pgadmin(at)pse-consulting(dot)de> |
| Subject: | Re: [HACKERS] For review: Server instrumentation patch |
| Date: | 2005-08-12 19:01:53 |
| Message-ID: | 21919.1123873313@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
I wrote:
> I'm not sure whether to export skip_drive from path.c or just duplicate
> it. If we do export it, a different name would probably be a good idea,
> as it seems too generic for a global symbol.
On reflection, there's another possibility, which is to put the test
code into path.c in the first place, defined something like
bool path_contains_parent_reference(const char *path);
This is probably better since the whole business of looking for ".."
seems like something that should be in path.c and not elsewhere.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2005-08-12 19:40:29 | Re: Bug in canonicalize_path() |
| Previous Message | Bruce Momjian | 2005-08-12 18:53:32 | Re: [HACKERS] data on devel code perf dip |